Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TravisCI Support #79

Merged
merged 1 commit into from
Jun 10, 2016
Merged

Add TravisCI Support #79

merged 1 commit into from
Jun 10, 2016

Conversation

jaredsburrows
Copy link
Contributor

@jagtejsodhi
Copy link

👍

@zhangkun83 zhangkun83 self-assigned this Jun 9, 2016
@jaredsburrows
Copy link
Contributor Author

@zhangkun83 The build is taking forever to start. I think TravisCI is overloaded today.

@ejona86
Copy link
Collaborator

ejona86 commented Jun 9, 2016

@jaredsburrows, this project is part of google GitHub organization, so we share a max of ~5 workers across all the repos. So it is pretty common to be overloaded. When I'm iterating trying to fix a problem with Travis I create a trash PR against my personal clone of the repo and Travis is much faster.

@jaredsburrows
Copy link
Contributor Author

@ejona86 Makes sense. All is well now!

@jaredsburrows
Copy link
Contributor Author

@zhangkun83 Anything else you wanted me to add in this PR?


matrix:
allow_failures:
- jdk: oraclejdk7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that with jdk7 it fails with OOM. Does it fail consistently? Because JDK7 is our releasing platform we need to make sure it builds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on your local system and memory, it may not. I just added that to show that it "can" compile with jdk7. We can probably remove it if you do not want it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejona86 is there a way to adjust the Xmx?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but you have to do it in the build.gradle file as a jvmOpt to test {} (or something like that). It isn't really possible to do it from the command line just from Travis, unless you are wanting to configure how much memory gradle uses for building in which case you would add it to the GRADLE_OPTS environment variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangkun83 @ejona86 I honestly rather not do that since you have to now hard code jvm args for the build. The build has a target/source of Java 1.7(no oracle support anymore) and uses jdk8.

I think it would be best if I just removed the jdk7 part. JDK8 automatically handles memory usage during builds.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@jaredsburrows
Copy link
Contributor Author

@zhangkun83 Alright. All fixed.

@zhangkun83
Copy link
Collaborator

One last thing: it doesn't seem to run the tests. Can you add test to the ./gradlew clean assemble line?

@jaredsburrows
Copy link
Contributor Author

@zhangkun83 Good eye. Done.

@zhangkun83 zhangkun83 merged commit faaa4fa into google:master Jun 10, 2016
@jaredsburrows jaredsburrows deleted the add-travis-ci-support branch June 10, 2016 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants