-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TravisCI Support #79
Conversation
👍 |
@zhangkun83 The build is taking forever to start. I think TravisCI is overloaded today. |
@jaredsburrows, this project is part of google GitHub organization, so we share a max of ~5 workers across all the repos. So it is pretty common to be overloaded. When I'm iterating trying to fix a problem with Travis I create a trash PR against my personal clone of the repo and Travis is much faster. |
@ejona86 Makes sense. All is well now! |
@zhangkun83 Anything else you wanted me to add in this PR? |
|
||
matrix: | ||
allow_failures: | ||
- jdk: oraclejdk7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that with jdk7 it fails with OOM. Does it fail consistently? Because JDK7 is our releasing platform we need to make sure it builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on your local system and memory, it may not. I just added that to show that it "can" compile with jdk7. We can probably remove it if you do not want it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ejona86 is there a way to adjust the Xmx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but you have to do it in the build.gradle file as a jvmOpt to test {}
(or something like that). It isn't really possible to do it from the command line just from Travis, unless you are wanting to configure how much memory gradle uses for building in which case you would add it to the GRADLE_OPTS
environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangkun83 @ejona86 I honestly rather not do that since you have to now hard code jvm args for the build. The build has a target/source of Java 1.7(no oracle support anymore) and uses jdk8.
I think it would be best if I just removed the jdk7 part. JDK8 automatically handles memory usage during builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
@zhangkun83 Alright. All fixed. |
One last thing: it doesn't seem to run the tests. Can you add |
@zhangkun83 Good eye. Done. |
@zhangkun83 @ejona86
Solves: #78