Do not use GenerateProtoTask as source of output dirs information (3/3) #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rougsig
changed the title
|
final fix for #643 |
|
Do not forget to update readme.md files. Will be in extra PR 4/3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
To prevent eager task configuration for android, we need to know the list of output folders from generate proto task.
Changes
Use
GenerateProtoTaskSpecas the source of trust for agp plugin. Just replaced usage ofGenerateProtoTasktoGenerateProtoTaskSpecTest plan
Green pipelines. No eager task configuration for android plugin part. Special test case was added.
Note
merge after #669
In java part we still have eager tasks configuration, if project have
ideaoreclipseplugin