Update protoc_plugin Makefile: #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update PLUGIN_SRC - No need to check the dir before calling `mkdir -p` as it succeeds when the dir already exists. Remove the check. - `build-plugin` target doesn't do anything, remove it. - Update `clean` dirs: we no longer have a `benchmark` dir in protoc_plugin.
sigurdm
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
PLUGIN_SRCNo need to check the dir before calling
mkdir -pas it succeeds when the dir already exists. Remove the check.build-plugintarget doesn't do anything, remove it.Update
cleandirs: we no longer have abenchmarkdir in protoc_plugin.