Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move native_enum_type_map into internals and remove cross_extension_shared_states feature. #30140

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

rwgk
Copy link
Contributor

@rwgk rwgk commented Jul 30, 2024

Description

Essentially this is rolling back #30008

Motivations:

Additional consideration:

  • It will probably be better and more general to establish a general cross-extension pointer-passing protocol that only requires C++ ABI compatibility, but does not make any assumptions about the internals of the implementations on both sides.

Merging this PR now to start work on git merge smart_holder.

Suggested changelog entry:

@rwgk rwgk changed the title WIP: Move native_enum_type_map into internals and remove cross_extension_shared_states feature. Move native_enum_type_map into internals and remove cross_extension_shared_states feature. Aug 3, 2024
@rwgk rwgk marked this pull request as ready for review August 3, 2024 13:50
@rwgk rwgk merged commit ab472bb into google:main Aug 3, 2024
155 checks passed
@rwgk rwgk deleted the remove_cross_extension_shared_state branch August 3, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant