Fix pandas.DataFrame support in core._PrintResult #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HasCustomRepr
check in value_typesIssue:
When calling
Fire
on a function that returns a pd.DataFrame, the _PrintResult function in core.py prints the manual for DataFrames from the pandas Docs to stdout.if value_types.HasCustomStr(result):
doesn't recognize the DataFrame's custom __str__ as it is simply seemingly inherited from the custom __repr__ for DataFrames.See pandas.core.frame.DataFrame.__repr__ which calls
.to_string()
).Due to this, the
_PrintResult
function displays the DataFrame'shelptext.HelpText
instead.This implementation should fix the issue.
Edit: Only seeing now that there is a related issue: #274