Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Exported Enum Values in JS #134

Merged
merged 2 commits into from
Nov 25, 2020

Conversation

Eyas
Copy link
Collaborator

@Eyas Eyas commented Nov 25, 2020

See #131 for a justification/discussion.

We'd rather users use:

const kneeReplacement: MedicalProcedure = {
  "@type": "MedicalProcedure",
  "procedureType": "PercutaneousProcedure", // or "https://schema.org/PercutaneousProcedure"
};

We already accept these as constant string literals, but now we'll remove the alternative, such as:

MedicalProcedureType.PercutaneousProcedure

@Eyas Eyas merged commit d5c3ff6 into google:master Nov 25, 2020
@Eyas Eyas deleted the deprecate-enum-value-js branch November 26, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant