Add strings.remove{pre,suf}fix methods #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentlb
approved these changes
Feb 15, 2022
starlark/library.go
Outdated
| if err := UnpackPositionalArgs(b.Name(), args, kwargs, 1, &fix); err != nil { | ||
| return nil, err | ||
| } | ||
| if b.name[6] == 'p' { |
There was a problem hiding this comment.
As the function is short, it might be worth duplicating it instead of using b.name magic.
If you want to keep it like this, add a comment on the line
There was a problem hiding this comment.
Since it's easy to avoid the duplication of source and object code (240 insns -> 160), and the cost of the extra load and two cjmps is trivial overall, I'd prefer to keep it this way.
But you're right it could be clearer. Commented in the form of self-documenting code:
if b.name[len("remove")] == 'p' {
|
@brandjon, can you approve? I assume @laurentlb did not because he no longer has the write bit. |
|
I don't think I've ever had write access in this repo. |
tetromino
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bazelbuild/starlark#212 for spec change
See bazelbuild/bazel#14824 for Java PR
See facebook/starlark-rust@7a7ef4b for Rust commit
Updates bazelbuild/starlark#185