New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable showing expression values #113

Merged

marcrasi merged 2 commits into master from fix_expression_value_showing

Sep 17, 2020

Contributor

marcrasi commented Sep 17, 2020

The recent merge causes LLDB to crash when it tries to show an expression value (with result.description).

This PR replaces all uses of result.description with a few different non-crashing alternatives:

When we know the type, of the value, use GetSignedInt32().
When GetDescription() works, use that.
In a case where even GetDescription() crashes, print a message telling the user that they can show the value using print(). I made Cannot show expression values #112 to track fixing this.


          disable showing expression values

b2a14d4

texasmichelle approved these changes

View reviewed changes


          fix test

1014ee0

marcrasi merged commit 05aa29b into master

marcrasi deleted the fix_expression_value_showing branch

September 17, 2020 18:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet