tools/syz-declextract: Code Restructuring

[pimyn-girgis]

No description provided.

[a-nogikh]

I wonder if struct fields that mention fd should also become fd? At least those that are of 32 bit.

[a-nogikh]

I wonder if struct fields that mention fd should also become fd? At least those that are of 32 bit.

Same for _pid, _uid, _tid.

[a-nogikh]

Do we currently support nested netlink policies? E.g. for ETHTOOL_A_TSINFO_HEADER it should definitely not be nlattr[ETHTOOL_A_TSINFO_HEADER, array[int8, 3]]

https://elixir.bootlin.com/linux/v6.11/source/net/ethtool/tsinfo.c#L26

[pimyn-girgis]

Do we currently support nested netlink policies? E.g. for ETHTOOL_A_TSINFO_HEADER it should definitely not be nlattr[ETHTOOL_A_TSINFO_HEADER, array[int8, 3]]

https://elixir.bootlin.com/linux/v6.11/source/net/ethtool/tsinfo.c#L26

No, these are not supported yet.

[a-nogikh]

Regarding the failing tests. They are due to this code preferring $auto-calls to their non-auto alternatives.

syzkaller/tools/syz-trace2syz/proggen/call_selector.go

Lines 169 to 182 in ba29ff7

	func (cs *defaultCallSelector) Select(call *parser.Syscall) *prog.Syscall {
	var match *prog.Syscall
	discriminators := discriminatorArgs[call.CallName]
	if len(discriminators) == 0 {
	return nil
	}
	score := 0
	for _, meta := range cs.callSet(call.CallName) {
	if score1 := cs.matchCall(meta, call, discriminators); score1 > score {
	match, score = meta, score1
	}
	}
	return match
	}

It's a good question whether $auto really have a higher score here or the scores are equal and $auto versions just happen to be earlier in callSet(). Let's just skip all auto-generated calls here for now:

syzkaller/tools/syz-trace2syz/proggen/call_selector.go

Lines 94 to 106 in ba29ff7

	func (cs *selectorCommon) callSet(callName string) []*prog.Syscall {
	calls, ok := cs.callCache[callName]
	if ok {
	return calls
	}
	for _, call := range cs.target.Syscalls {
	if call.CallName == callName {
	calls = append(calls, call)
	}
	}
	cs.callCache[callName] = calls
	return calls
	}

[dvyukov]

Otherwise looks good.