Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push to GitHub 2022-11-24 #28

Closed
wants to merge 1 commit into from

Conversation

JackyKaoGoogle
Copy link
Collaborator

No description provided.

@PatrykMis
Copy link

Great news, thanks for this! Hope it will be merged soon.

@PatrykMis
Copy link

Seams there is major issue with this push.

Google forgot to include source code of screenunderstanding library, there is only prebuilt .arr file.

@JackyKaoGoogle
Copy link
Collaborator Author

What's the issue and where can I see it?
I can build pass and run this project in the device. What's the screenunderstanding library and where should I put it?

@PatrykMis
Copy link

https://github.com/JackyKaoGoogle/talkback/blob/master/talkback/src/main/libs/screen_understanding.aar

It is precompiled library with obfuscation enabled, so to be clear and fair TalkBack is becoming more and more closed-source.

@thestinger could you explain it better with licensing issue background?

@JackyKaoGoogle
Copy link
Collaborator Author

I will check how to replace this library by the source codes.

@beqabeqa473
Copy link

@JackyKaoGoogle is there any progress?

i'm now learning internals of talkback to optimize it for specific android device.

Could you please state a clear official position on screen understanding library so we can clearly understand what is happening with that?

Why it is closed source?

@thestinger
Copy link

We moved to GrapheneOS being based on this and there are substantial issues with it. People are reporting that the Braille keyboard doesn't work anymore. It's not a good situation. We aren't sure if we can safely downgrade it.

@JackyKaoGoogle
Copy link
Collaborator Author

Thanks all.
After checking with folks internally, this library is only for the partners, and doesn't need to release to Public. So I will abandon this PR!

@thestinger
Copy link

@JackyKaoGoogle Is the open source talkback going to continue to receive updates, or is that ending? If it depends on this library and it can't simply be omitted, does that imply the open source releases are ending?

@JackyKaoGoogle
Copy link
Collaborator Author

Yes, the open source releasing is ending.

@thestinger
Copy link

That's extremely disappointing. It would have been nice if Google released more of the accessibility services as open source and provided more frequent updates for them instead of moving away from it.

@thestinger
Copy link

I'm confused about this since bdead86 was pushed.

@JackyKaoGoogle
Copy link
Collaborator Author

We don't move away this new updates, and just release this version to open source through another way. I release the same version without this library to open source directly after I got the right for releasing codes for the google/talkback project.

@beqabeqa473
Copy link

@JackyKaoGoogle why open source google/talkback doesn't include braille display implementation? only stub class why does absolutely nothing.

I think it is a bit unserious doing such things and not telling anything somewhere.
people are not PIGS to behave like talkback team is behaving.

@devinprater
Copy link

devinprater commented Jan 6, 2023 via email

@JackyKaoGoogle
Copy link
Collaborator Author

The reason is Braille display was announced in July 2022, so the open-source might haven't included it.
We will plan to open-source it in the next version.

@flawedworld
Copy link

The reason is Braille display was announced in July 2022, so the open-source might haven't included it. We will plan to open-source it in the next version.

So just to be clear here, will talkback releases continue to be made here? Or is that going to end? If it is going to end, when will that be?

@JackyKaoGoogle
Copy link
Collaborator Author

We wil release the TalkBack directly, and won't use the "Pull Request" way!
This pull request, Push to GitHub 2022-11-24
#28, is ended.

@flawedworld
Copy link

We wil release the TalkBack directly, and won't use the "Pull Request" way! This pull request, Push to GitHub 2022-11-24 #28, is ended.

Ah, so Google does intend to push future releases of talkback to the main branch of https://github.com/google/talkback ? This is not stopping?

@JackyKaoGoogle
Copy link
Collaborator Author

Yes, we will push future releases of talkback to the main branch of https://github.com/google/talkback!

@akash07k
Copy link

akash07k commented Jan 10, 2023

@JackyKaoGoogle
Can't Google make Talkback a true open source project?
I mean to say that, it will be great if the Talkback project starts getting regular commits and pushes from Google team instead of pushing them anually/in 6 months.
It will be even better if it can be considered as a true open source project by Google, where all the Talkback development takes place in the public repo, accepting the contribution/PRs from the people, listening community feedback, creating a roadmap, issue tracker, and everything on GitHub?
To mention, none of the pull request made is accepted by Google and it is very disappointing.
Making Talkback a true, open source project will make the things better for everyone.

@devinprater
Copy link

devinprater commented Jan 10, 2023 via email

@akash07k
Copy link

akash07k commented Apr 10, 2023

@JackyKaoGoogle Any update on this?
Is google planning to push the latest 13.1 sources anytime soon?

@JackyKaoGoogle Can't Google make Talkback a true open source project? I mean to say that, it will be great if the Talkback project starts getting regular commits and pushes from Google team instead of pushing them anually/in 6 months. It will be even better if it can be considered as a true open source project by Google, where all the Talkback development takes place in the public repo, accepting the contribution/PRs from the people, listening community feedback, creating a roadmap, issue tracker, and everything on GitHub? To mention, none of the pull request made is accepted by Google and it is very disappointing. Making Talkback a true, open source project will make the things better for everyone.

@beqabeqa473
Copy link

@JackyKaoGoogle hello.

Are there any news about next open-source talkback release?

There are interesting features which we want to have in open-source builds.

Thanks.

@PatrykMis
Copy link

@beqabeqa473 exactly.
cc @simplexatg @ChadBrowerAtGoogle

@vgonda
Copy link

vgonda commented Feb 28, 2024

Yes, we will push future releases of talkback to the main branch of https://github.com/google/talkback!

@JackyKaoGoogle Any updates here? Looks like this repo hasn't been updated in 2 years.

cc/ @zach-klippenstein @Erito

@PatrykMis
Copy link

@JackyKaoGoogle @simplexatg @ChadBrowerAtGoogle It's been over a year without any pushes to GitHub for the TalkBack source code. We're eagerly awaiting your contributions, especially with the absence of releases in the v14.x range. Please prioritize pushing the latest changes. Thank you.

@beqabeqa473
Copy link

@JackyKaoGoogle @simplexatg @ChadBrowerAtGoogle joining to this discussion. Here is an android device in the work which will use talkback, but it was not updated for a while. Please pay an attention to 3rd-party devs and push latest changes.

@simplexatg simplexatg closed this Mar 2, 2024
@beqabeqa473
Copy link

hello @JackyKaoGoogle @simplexatg @ChadBrowerAtGoogle Sorry for mentioning you in closed pull request, this is because there are no issues permitted and this pr is most applicable for this kind of thing. Could you please tell us when tb 15 will be pushed to github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants