Skip to content

Commit

Permalink
Merge pull request #114 from google/mac/notification
Browse files Browse the repository at this point in the history
Migrate alerter to "User Notifications" framework
  • Loading branch information
BobEvans authored Jan 14, 2022
2 parents 160015c + 307bb62 commit dd7c679
Show file tree
Hide file tree
Showing 14 changed files with 785 additions and 651 deletions.
3 changes: 3 additions & 0 deletions pal_event_server/lib/src/daemon/daemon.dart
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import '../sqlite_database/sqlite_database.dart';
import 'alarm_manager.dart' as alarm_manager;
import 'notification_manager.dart' as notification_manager;
import 'linux/dbus_notifications.dart' as linux_notifications;
import 'macos/alerter_notifications.dart' as macos_notifications;

final _logger = Logger('Daemon');

Expand Down Expand Up @@ -88,6 +89,8 @@ void start() async {
if (Platform.isLinux) {
// Monitor DBus for notification actions
linux_notifications.monitor();
} else if (Platform.isMacOS) {
macos_notifications.askNotificationPermission();
}

// Schedule
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ import 'package:logging/logging.dart';

import '../daemon.dart' as daemon;

const _alerterBinary = '/Applications/Taqo.app/Contents/MacOS/alerter';
const _bundleId = '/com.taqo.survey.taqoClient';
const _alerterBinary = '/Applications/Taqo.app/Contents/Frameworks/alerter.app/Contents/MacOS/alerter';
const _bundleId = 'com.taqo.survey.taqoClient';

final _logger = Logger('AlerterNotifications');

Expand Down Expand Up @@ -59,7 +59,6 @@ Future<int> notify(int id, String title, String body, {int timeout = 0}) async {
'-title', title, //
'-message', body,
'-timeout', '$timeout',
'-sender', _bundleId,
'-group', '$id',
'-json',
]).then((Process p) {
Expand All @@ -75,3 +74,7 @@ Future<int> notify(int id, String title, String body, {int timeout = 0}) async {
_notifications.add(id);
return id;
}

Future<void> askNotificationPermission() async {
await Process.run(_alerterBinary, ['-permission']);
}
315 changes: 190 additions & 125 deletions taqo_client/macos/Runner.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,33 @@
allowLocationSimulation = "YES">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "511EEE15273DD29A00BCB07C"
BuildableName = "alerter.app"
BlueprintName = "alerter"
ReferencedContainer = "container:Runner.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
<MacroExpansion>
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "33CC10EC2044A3C60003C045"
BuildableName = "Taqo.app"
BlueprintName = "Runner"
ReferencedContainer = "container:Runner.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</MacroExpansion>
<CommandLineArguments>
<CommandLineArgument
argument = "-message Hello"
isEnabled = "YES">
</CommandLineArgument>
<CommandLineArgument
argument = "-group 1"
isEnabled = "YES">
</CommandLineArgument>
</CommandLineArguments>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1300"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "511EEE15273DD29A00BCB07C"
BuildableName = "alerter.app"
BlueprintName = "alerter"
ReferencedContainer = "container:Runner.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
</BuildAction>
<TestAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES">
<Testables>
</Testables>
</TestAction>
<LaunchAction
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES"
debugServiceExtension = "internal"
allowLocationSimulation = "YES">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "511EEE15273DD29A00BCB07C"
BuildableName = "alerter.app"
BlueprintName = "alerter"
ReferencedContainer = "container:Runner.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
<CommandLineArguments>
<CommandLineArgument
argument = "-message Hello"
isEnabled = "YES">
</CommandLineArgument>
<CommandLineArgument
argument = "-group 1"
isEnabled = "YES">
</CommandLineArgument>
</CommandLineArguments>
</LaunchAction>
<ProfileAction
buildConfiguration = "Release"
shouldUseLaunchSchemeArgsEnv = "YES"
savedToolIdentifier = ""
useCustomWorkingDirectory = "NO"
debugDocumentVersioning = "YES">
<BuildableProductRunnable
runnableDebuggingMode = "0">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "511EEE15273DD29A00BCB07C"
BuildableName = "alerter.app"
BlueprintName = "alerter"
ReferencedContainer = "container:Runner.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</ProfileAction>
<AnalyzeAction
buildConfiguration = "Debug">
</AnalyzeAction>
<ArchiveAction
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
10 changes: 5 additions & 5 deletions taqo_client/macos/Runner/Base.lproj/MainMenu.xib
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="14490.70" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="19162" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
<dependencies>
<deployment identifier="macosx"/>
<plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="14490.70"/>
<plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="19162"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
<objects>
Expand All @@ -13,7 +13,7 @@
</customObject>
<customObject id="-1" userLabel="First Responder" customClass="FirstResponder"/>
<customObject id="-3" userLabel="Application" customClass="NSObject"/>
<customObject id="Voe-Tx-rLC" customClass="AppDelegate" customModule="Runner" customModuleProvider="target">
<customObject id="Voe-Tx-rLC" customClass="AppDelegate" customModule="Taqo" customModuleProvider="target">
<connections>
<outlet property="applicationMenu" destination="uQy-DD-JDr" id="XBo-yE-nKs"/>
<outlet property="mainFlutterWindow" destination="QvC-M9-y7g" id="gIp-Ho-8D9"/>
Expand Down Expand Up @@ -326,10 +326,10 @@
</items>
<point key="canvasLocation" x="142" y="-258"/>
</menu>
<window title="APP_NAME" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" releasedWhenClosed="NO" animationBehavior="default" id="QvC-M9-y7g" customClass="MainFlutterWindow" customModule="Runner" customModuleProvider="target">
<window title="APP_NAME" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" releasedWhenClosed="NO" animationBehavior="default" id="QvC-M9-y7g" customClass="MainFlutterWindow" customModule="Taqo" customModuleProvider="target">
<windowStyleMask key="styleMask" titled="YES" closable="YES" miniaturizable="YES" resizable="YES"/>
<rect key="contentRect" x="335" y="390" width="800" height="600"/>
<rect key="screenRect" x="0.0" y="0.0" width="2560" height="1577"/>
<rect key="screenRect" x="0.0" y="0.0" width="1440" height="875"/>
<view key="contentView" wantsLayer="YES" id="EiT-Mj-1SZ">
<rect key="frame" x="0.0" y="0.0" width="800" height="600"/>
<autoresizingMask key="autoresizingMask"/>
Expand Down
10 changes: 10 additions & 0 deletions taqo_client/macos/alerter/Info.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>LSUIElement</key>
<true/>
<key>NSUserNotificationAlertStyle</key>
<string>alert</string>
</dict>
</plist>
19 changes: 19 additions & 0 deletions taqo_client/macos/alerter/InfoPlist.strings
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/*
InfoPlist.strings
Runner

Copyright 2021 Google LLC

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
CFBundleDisplayName = "Taqo";
31 changes: 31 additions & 0 deletions taqo_client/macos/alerter/NotificationWithState.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#ifndef NotificationWithState_h
#define NotificationWithState_h

#import <Foundation/Foundation.h>
#import <UserNotifications/UserNotifications.h>


@interface NotificationWithState : NSObject <NSSecureCoding>

@property (readonly) NSString *state;
@property (readonly) UNNotification *notification;

+ (instancetype) notification: (UNNotification *) notification state: (NSString *) state;

@end

#endif /* NotificationWithState_h */
53 changes: 53 additions & 0 deletions taqo_client/macos/alerter/NotificationWithState.m
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#import "NotificationWithState.h"

@implementation NotificationWithState


- (void)encodeWithCoder:(nonnull NSCoder *)coder {
[coder encodeObject:_state forKey:@"state"];
[coder encodeObject:_notification forKey:@"notification"];
}

- (nullable instancetype)initWithCoder:(nonnull NSCoder *)coder {
self = [super init];
if (self) {
_state = [coder decodeObjectOfClass:[NSString class] forKey:@"state"];
_notification = [coder decodeObjectOfClass:[UNNotification class] forKey:@"notification"];
}
return self;
}

- (nullable instancetype) initWithNotification:(UNNotification *) notification state: (NSString *) state;
{
self = [super init];
if (self) {
_state = state;
_notification = notification;
}
return self;
}

+ (instancetype) notification: (UNNotification *) notification state: (NSString *) state {
return [[[self class] alloc] initWithNotification:notification state:state];
}

+ (BOOL) supportsSecureCoding {
return YES;
}


@end
5 changes: 5 additions & 0 deletions taqo_client/macos/alerter/alerter.entitlements
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict/>
</plist>
6 changes: 3 additions & 3 deletions taqo_client/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ packages:
name: async
url: "https://pub.dartlang.org"
source: hosted
version: "2.8.2"
version: "2.8.1"
boolean_selector:
dependency: transitive
description:
Expand Down Expand Up @@ -393,7 +393,7 @@ packages:
name: matcher
url: "https://pub.dartlang.org"
source: hosted
version: "0.12.11"
version: "0.12.10"
meta:
dependency: transitive
description:
Expand Down Expand Up @@ -685,7 +685,7 @@ packages:
name: test_api
url: "https://pub.dartlang.org"
source: hosted
version: "0.4.3"
version: "0.4.2"
timezone:
dependency: "direct main"
description:
Expand Down
3 changes: 2 additions & 1 deletion third_party/alerter/alerter/AppDelegate.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#import <Cocoa/Cocoa.h>
#import <UserNotifications/UserNotifications.h>

@interface AppDelegate : NSObject <NSApplicationDelegate, NSUserNotificationCenterDelegate>
@interface AppDelegate : NSObject <NSApplicationDelegate, UNUserNotificationCenterDelegate>
-(void)bye;
@end
Loading

0 comments on commit dd7c679

Please sign in to comment.