Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possibilities for crashing in pal event helper insert event #202

Closed
BobEvans opened this issue Sep 19, 2023 · 2 comments · Fixed by #207
Closed

Investigate possibilities for crashing in pal event helper insert event #202

BobEvans opened this issue Sep 19, 2023 · 2 comments · Fixed by #207

Comments

@BobEvans
Copy link
Collaborator

Server logs show a restart for one participant after the log event "inserting event..."

There is likely a crash in this flow that needs to be guarded against.

T14:35:26.809583+00:00 INFO [SyncService]: Syncing public events complete.
2023-09-19T14:36:16.311160+00:00 INFO [PalEventHelper]: inserting event2023-09-19T15:15:26.659394+00:00 INFO [Main]: Logging service is ready
2023-09-19T15:15:26.661183+00:00 INFO [MachineId]: Machine ID: 84f36828-4ec5-4d7a-8413-326b0bdd2675

@BobEvans
Copy link
Collaborator Author

More evidence, later in the same log

2023-09-19T15:15:28.778500+00:00 INFO [SyncService]: Syncing public events complete.
**2023-09-19T15:15:36.693225+00:00 INFO [PalEventHelper]: inserting event2023-09-**19T15:54:00.519456+00:00 INFO [Main]: Logging service is ready
2023-09-19T15:54:00.520728+00:00 INFO [MachineId]: Machine ID: 84f36828-4ec5-4d7a-8413-326b0bdd2675
2023-09-19T15:54:00.521214+00:00 INFO [Main]: Server ready

@BobEvans
Copy link
Collaborator Author

This is likely some funky data hitting the allowlist.filterData method. Add more error handling and logging there.

BobEvans pushed a commit that referenced this issue Sep 19, 2023
rundong08 added a commit that referenced this issue Sep 20, 2023
fix #202 add more error handling to allowlist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant