Issue 102 #103
Merged
Issue 102 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rundong08
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Thanks! It LGTM, although it seems still possible to have race conditions when multiple write happens. But I suspect fixing that would require a redesign of taqo_shared_prefs. And since in practice this PR fixes existing issues without triggering new issues yet. I'll just merge this PR.
|
Thanks! One easy thought is that we could make the calls synchronous so that the two await calls inside the method go away. Then other callers would be blocked on writing. Given the amount of data we are processing, it might not be a bottleneck and it would be safe. Am I missing anything? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102