Issue 104 #106
Merged
Issue 104 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would happen if one clicked the notification near the expiration time, and then, when the survey is submitted the alarm got expired? Will the survey not being submitted? |
It would get reported as a self-report. |
I see, thanks! |
rundong08
approved these changes
Nov 5, 2021
|
Also, there would be a missed response registered when it expired so the researcher could see how late they were. Alternatively, ideally, we could pass the time in the notification to the launch of the app. This is how it worked at one point on android. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
survey page looked for pending alarms and took first one but this allowed uncleaned up but expired alarms to be chosen for the scheduleTime field. Now ignoring expired alarms.