Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server log local time #110

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Server log local time #110

merged 2 commits into from
Nov 5, 2021

Conversation

BobEvans
Copy link
Collaborator

@BobEvans BobEvans commented Nov 5, 2021

Fixes #39

@BobEvans
Copy link
Collaborator Author

BobEvans commented Nov 5, 2021

Sorry, this one is stacked on top of the set icons PR for macos app. I thought i switched to develop first but apparently not.

@BobEvans
Copy link
Collaborator Author

BobEvans commented Nov 5, 2021

This still has the issue you mentioned in the bug with log anachronisms however, log rotation should work and the anachronism, which is a corner case in general should usually be obvious in the logs. The pain of debugging and having to think in utc was greater in the moment.

@rundong08 rundong08 changed the base branch from develop to notification_logger_minifix November 5, 2021 23:23
@rundong08 rundong08 changed the base branch from notification_logger_minifix to develop November 5, 2021 23:23
@rundong08
Copy link
Collaborator

This still has the issue you mentioned in the bug with log anachronisms however, log rotation should work and the anachronism, which is a corner case in general should usually be obvious in the logs. The pain of debugging and having to think in utc was greater in the moment.

I agree. I realized that it is not worthy to pay the debugging pain for a corner case that rarely happen, especially when the corner case won't crash the app...

@rundong08 rundong08 merged commit ee461a7 into develop Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger should log in local timezone with timezone attached
2 participants