Add server log for crashes #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, all the server logs should go to the one used by Taqo's logging service, i.e. server-yyyy-MM-dd.log, which is managed within Dart. However, it might be not straightforward to catch fatal errors from within Dart. Since taqo_daemon is now called from TaqoLauncher, we could redirect taqo_daemon's stdout and stderr to different log files. Again, these stdout and stderr logs ideally should be managed by some rotation strategy. However, keeping the stdout and stderr only for the latest run is much simpler to implement and enough for our current debugging activities. Hence that is the way I pick here.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, all the server logs should go to the one used by Taqo's logging
service, i.e. server-yyyy-MM-dd.log, which is managed within Dart.
However, it might be not straightforward to catch fatal errors from
within Dart. Since taqo_daemon is now called from TaqoLauncher, we could
redirect taqo_daemon's stdout and stderr to different log files. Again,
these stdout and stderr logs ideally should be managed by some rotation
strategy. However, keeping the stdout and stderr only for the latest run
is much simpler to implement and enough for our current debugging
activities. Hence that is the way I pick here.