Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue 156 #163

Merged
merged 3 commits into from
Aug 31, 2023
Merged

issue 156 #163

merged 3 commits into from
Aug 31, 2023

Conversation

BobEvans
Copy link
Collaborator

Fixes #<156>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

rundong08
rundong08 reviewed Aug 26, 2023
View reviewed changes
pal_event_server/test/dbus_notifications_test.dart
{
test('notificationWithEmptyEventAndNoNotificationsOutstanding', () {
notifications = <int, int>{};
listen("");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some comments here about expected behavior, such as expected to do nothing and generate no errors?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added descriptions. Please take a look. Let me know if this is what you had in mind?

pal_event_server/test/dbus_notifications_test.dart Outdated Show resolved Hide resolved
rundong08
rundong08 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@rundong08 rundong08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates Bob! Just found one typo.

pal_event_server/test/dbus_notifications_test.dart Outdated Show resolved Hide resolved
@rundong08 rundong08 merged commit 0e9176f into develop Aug 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rundong08 rundong08 rundong08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobEvans @rundong08