Add idle time support #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobEvans
reviewed
Sep 14, 2023
| isIdle() | ||
| ]).then((result) { | ||
| final currWindow = (result[0] as ProcessResult).stdout; | ||
| final idleState = result[1]; |
There was a problem hiding this comment.
what happens if the process crashes? Can result[1] ever cause an out of bounds access problem?
There was a problem hiding this comment.
If the process crashes, ProcessResult will still be generated with an non-zero exit code, the stdout will probably be empty or garbage but those were handled. If one of the Process.run throws an exception then the then body will not be executed and the error will be caught by the catchError below.
BobEvans
reviewed
Sep 14, 2023
| isIdle() | ||
| ]).then((result) { | ||
| final currWindow = (result[0] as ProcessResult).stdout.trim(); | ||
| final idleState = result[1]; |
There was a problem hiding this comment.
is it possible to get an out of bounds error here?
|
Thanks! Looks great! Just a few small questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
Fixes #180