Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS desktop tracer record correct app title #218

Merged
merged 3 commits into from
Sep 26, 2023
Merged

macOS desktop tracer record correct app title #218

merged 3 commits into from
Sep 26, 2023

Conversation

rundong08
Copy link
Collaborator

Fixed #148

@rundong08
Copy link
Collaborator Author

The app name now works but the window title is still now working well. I will try to fix it.

@BobEvans
Copy link
Collaborator

Is this just correct title for Chrome apps? Will Electron (VS Code) allowlist will be a separate CL?

@rundong08
Copy link
Collaborator Author

Is this just correct title for Chrome apps? Will Electron (VS Code) allowlist will be a separate CL?

Electron Apps will also be correctly recognized, e.g. VS Code will be identified as Code.

@BobEvans
Copy link
Collaborator

Cool. Let me know when it is ready.

@rundong08
Copy link
Collaborator Author

Hi Bob,
This PR is now ready for review.
Window title is now properly handled. In applescript using of me after an object specifier will go back to the top level "namespace".

@BobEvans BobEvans merged commit 2e09772 into develop Sep 26, 2023
4 checks passed
@BobEvans
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobEvans BobEvans BobEvans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOs windowed app tracing does not properly show Chrome apps & Electron apps
2 participants
@rundong08 @BobEvans