Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go mod to 1.17 with: go mod tidy -go=1.17 #2768

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Update go mod to 1.17 with: go mod tidy -go=1.17 #2768

merged 1 commit into from
Jun 28, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jun 28, 2022 •
edited
Loading

Signed-off-by: Ville Aikas vaikas@chainguard.dev

As discussed in #2754 split out the go.mod changes to a separate PR.

Update the go.mod to tidy with 1.17 compatibility.

Checklist

@vaikas vaikas requested a review from a team as a code owner June 28, 2022 10:13
@vaikas vaikas requested a review from getagit June 28, 2022 10:13
@vaikas
Update go mod to 1.17 with: go mod tidy -go=1.17
45ca451 
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas force-pushed the update-to-go-mod-17 branch from 5e1d19b to 45ca451 Compare June 28, 2022 10:14
@vaikas vaikas changed the title [WIP] Update go mod to 1.17 with: go mod tidy -go=1.17 Update go mod to 1.17 with: go mod tidy -go=1.17 Jun 28, 2022
@vaikas vaikas mentioned this pull request Jun 28, 2022
Open
2 tasks
@roger2hk
Copy link
Contributor

/gcbrun

roger2hk
roger2hk approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@roger2hk roger2hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upgraded the go version in my local branch. The file difference is the same.

@roger2hk roger2hk mentioned this pull request Jun 28, 2022
Merged
2 tasks
@roger2hk roger2hk merged commit f8803d4 into google:master Jun 28, 2022
@vaikas vaikas deleted the update-to-go-mod-17 branch June 29, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pav-kv pav-kv pav-kv approved these changes

@roger2hk roger2hk roger2hk approved these changes

@getagit getagit Awaiting requested review from getagit getagit is a code owner automatically assigned from google/trillian-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaikas @roger2hk @pav-kv