Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated prune-whitelist flag with prune-allowlist for kubectl command #3307

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Jan 21, 2024

Warning message from the Google Cloud Build:

Step #10 - "apply_k8s_cfgs_for_mysql_dryrun": Running: kubectl apply --dry-run=server --namespace=mysql -f=envsubst-mysql/etcd-cluster.yaml -f=envsubst-mysql/trillian-ci-mysql.yaml -f=envsubst-mysql/trillian-mysql.yaml -f=envsubst-mysql/trillian-log-deployment.yaml -f=envsubst-mysql/trillian-log-service.yaml -f=envsubst-mysql/trillian-log-signer-deployment.yaml -f=envsubst-mysql/trillian-log-signer-service.yaml --prune --all --prune-whitelist=core/v1/ConfigMap
Step #10 - "apply_k8s_cfgs_for_mysql_dryrun": Flag --prune-whitelist has been deprecated, Use --prune-allowlist instead.

Checklist

@roger2hk
Copy link
Contributor Author

roger2hk commented Jan 23, 2024

trillian-pr-deploy (trillian-opensource-ci) is failed due to the deprecated GKE version running behind the scene.

Step #10 - "apply_k8s_cfgs_for_mysql_dryrun": Running: kubectl apply --dry-run=server --namespace=mysql -f=envsubst-mysql/etcd-cluster.yaml -f=envsubst-mysql/trillian-ci-mysql.yaml -f=envsubst-mysql/trillian-mysql.yaml -f=envsubst-mysql/trillian-log-deployment.yaml -f=envsubst-mysql/trillian-log-service.yaml -f=envsubst-mysql/trillian-log-signer-deployment.yaml -f=envsubst-mysql/trillian-log-signer-service.yaml --prune --all --prune-allowlist=core/v1/ConfigMap
Step #10 - "apply_k8s_cfgs_for_mysql_dryrun": error: unknown flag: --prune-allowlist

kubernetes/kubernetes#113116

@roger2hk roger2hk marked this pull request as ready for review April 19, 2024 22:03
@roger2hk roger2hk requested a review from a team as a code owner April 19, 2024 22:03
@roger2hk
Copy link
Contributor Author

The GKE version is now 1.26 in GCP, so the check is now passed.

@roger2hk roger2hk merged commit 847b10f into google:master Apr 22, 2024
10 checks passed
@roger2hk roger2hk deleted the kubectl-prune-list branch April 22, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants