-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control included quota and storage providers via build tags #3664
Merged
phbnf
merged 7 commits into
google:master
from
robstradling:cmd_storage_quota_build_tags
Nov 8, 2024
Merged
Control included quota and storage providers via build tags #3664
phbnf
merged 7 commits into
google:master
from
robstradling:cmd_storage_quota_build_tags
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/gcbrun |
Looks neat, thanks. Do you mind adding an entry in |
… Package Layout section of storage/README.md
Hi @phbnf. Done. |
/gcbrun |
phbnf
approved these changes
Nov 8, 2024
Thanks @robstradling ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3644 (comment) noted that the log-signer and log-server binaries are huge, due in part to the presence of multiple quota and storage providers. This PR enables providers to be included selectively via Go build tags.
By default and for backwards compatibility, all providers are included:
Specify one build tag to include just one provider:
Specify multiple, comma-separated build tags to include multiple providers. e.g.,:
Checklist