Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a long-standing bug with type annotation paths on raw inner class types #287

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

Fix a long-standing bug with type annotation paths on raw inner class types

As described in JVMS
4.7.20.2
,
type annotations on nested types are located with type_path_kind=1 type path
entries, which describe steps starting with the 'outermost part of the type for
which a type annotation is admissible'.

Turbine represents class types for inner classes as a flat list of 'simple
class types' corresponding to outer and inner classes. The 'canonicalization'
step normalizes type arguments, and also ensures there's exactly one entry for
each nested class and non-static containing class. The former doesn't apply to
raw types (we erase the entire type if any part of it is raw), but the latter
is important to ensure we compute the right number of type path steps for inner
classes.

@copybara-service copybara-service bot closed this Oct 26, 2023
@copybara-service copybara-service bot deleted the test_main_576191070 branch October 26, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants