Fix a long-standing bug with type annotation paths on raw inner class types #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a long-standing bug with type annotation paths on raw inner class types
As described in JVMS
4.7.20.2,
type annotations on nested types are located with
type_path_kind=1
type pathentries, which describe steps starting with the 'outermost part of the type for
which a type annotation is admissible'.
Turbine represents class types for inner classes as a flat list of 'simple
class types' corresponding to outer and inner classes. The 'canonicalization'
step normalizes type arguments, and also ensures there's exactly one entry for
each nested class and non-static containing class. The former doesn't apply to
raw types (we erase the entire type if any part of it is raw), but the latter
is important to ensure we compute the right number of type path steps for inner
classes.