Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback further #62

Merged
merged 3 commits into from
Jun 13, 2014
Merged

Address feedback further #62

merged 3 commits into from
Jun 13, 2014

Conversation

addyosmani
Copy link
Contributor

For #60

sindresorhus
sindresorhus reviewed Jun 13, 2014
View reviewed changes
app/index.html
@@ -93,5 +86,6 @@ <h1 class="logo">Web Starter Kit</h1>
r.parentNode.insertBefore(e,r)}(window,document,'script','ga'));
ga('create','UA-XXXXX-X');ga('send','pageview');
</script>
<!-- Built with love using Web Starter Kit -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already added this in #61

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped it in eff2bbe so it could be moved lower down the page.

sindresorhus added a commit that referenced this pull request Jun 13, 2014
@sindresorhus
Merge pull request #62 from google/feedback
f8f7fd8 
Address feedback further
@sindresorhus sindresorhus merged commit f8f7fd8 into master Jun 13, 2014
@sindresorhus
Copy link
Contributor

👍

@sindresorhus sindresorhus deleted the feedback branch June 13, 2014 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyosmani @sindresorhus