Remove GO111MODULE=auto from Travis. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banaag
approved these changes
May 15, 2020
README.md
Outdated
| @@ -86,6 +86,9 @@ availability) at this moment. | |||
| go get -u github.com/google/webpackager/cmd/... | |||
| ``` | |||
|
|
|||
| **Note:** Currently Web Packager compiles on Go 1.11+ but you need to enable | |||
| Go modules (by settting `GO111MODULE=on`) if using Go 1.11. | |||
There was a problem hiding this comment.
Fixed. Go 1.13+ doesn't require GO111MODULE=on:
golang/go#31857
(I assumed this behavior to be for Go 1.12+ though).
webpackager no longer compiles without Go modules: the latest version of github.com/hashicorp/go-multierror requires Go 1.14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpackager no longer compiles without Go modules: the latest version of github.com/hashicorp/go-multierror requires Go 1.14.