Fix: Update golang.org/x/tools dependency to support Go v1.22.0 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This was referenced Feb 7, 2024
Closed
|
Maintainers, please also tag a release after merging. |
|
@zombiezen @vangent it looks like this repo might not be monitored closely at this point. sorry for the ping, but could one of you help with a review on this one? |
|
Looks like you'll need to update the GitHub Actions workflows as well. |
|
@zombiezen thanks for the review. updated the action in c0cebf2 |
vangent
approved these changes
Feb 7, 2024
|
@vangent, would you mind tagging the release once this goes in? Thanks. |
3 tasks
trunk-io bot
referenced
this pull request
in ride-app/driver-service
Feb 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/google/wire](https://togithub.com/google/wire) | `v0.5.0` -> `v0.6.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>google/wire (github.com/google/wire)</summary> ### [`v0.6.0`](https://togithub.com/google/wire/releases/tag/v0.6.0) [Compare Source](https://togithub.com/google/wire/compare/v0.5.0...v0.6.0) #### New Contributors - [@​rsc](https://togithub.com/rsc) made their first contribution in [https://github.com/google/wire/pull/339](https://togithub.com/google/wire/pull/339) - [@​giautm](https://togithub.com/giautm) made their first contribution in [https://github.com/google/wire/pull/353](https://togithub.com/google/wire/pull/353) - [@​wirekang](https://togithub.com/wirekang) made their first contribution in [https://github.com/google/wire/pull/357](https://togithub.com/google/wire/pull/357) - [@​efueyo](https://togithub.com/efueyo) made their first contribution in [https://github.com/google/wire/pull/360](https://togithub.com/google/wire/pull/360) - [@​stytchiz](https://togithub.com/stytchiz) made their first contribution in [https://github.com/google/wire/pull/365](https://togithub.com/google/wire/pull/365) - [@​toddtreece](https://togithub.com/toddtreece) made their first contribution in [https://github.com/google/wire/pull/401](https://togithub.com/google/wire/pull/401) **Full Changelog**: google/wire@v0.5.0...v0.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/driver-service). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
3 tasks
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm still getting the following panic with wire 0.6.0 against golang 1.22.5: |
|
@Resisty , per my understanding, if the wire tool you used is actually 0.6.0, the version of package golang.org/x/tools displayed in your backtrace should be 0.17.0 ，please make a check on this file wire go.mod . The latest wire works well with the go 1.22.5 at my env. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
golang.org/x/toolsgofmtfixes suggested byinternal/runtests.shalldepsupdates suggested byinternal/runtests.shWhy
I encountered this error during wire generation when trying to build Grafana with Go v1.22.0: