Skip to content

Commit

Permalink
Re-enable test_new_error() for i686 target (#42)
Browse files Browse the repository at this point in the history
The test_new_error() test was disabled for i686 due to Issue #21. This
issue has since been fixed in #28, but the test was not re-enabled.
  • Loading branch information
frazar authored Oct 10, 2022
1 parent 6aea74e commit c5af8fe
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ jobs:
# Skip the `ui` test since it invokes the compiler, which we can't do from
# Miri (and wouldn't want to do anyway).
#
# TODO(#21): Fix `test_new_error` on i686 and re-enable it here.
run: cargo +${{ matrix.channel }} miri test --target ${{ matrix.target }} --features "${{ matrix.features }}" -- --skip ui ${{ contains(matrix.target, 'i686') && '--skip test_new_error' || '' }}
run: cargo +${{ matrix.channel }} miri test --target ${{ matrix.target }} --features "${{ matrix.features }}" -- --skip ui
# Only nightly has a working Miri, so we skip installing on all other
# toolchains.
#
Expand Down

0 comments on commit c5af8fe

Please sign in to comment.