Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that derive macros create impls for multiple traits #2037

Closed
lolbinarycat opened this issue Nov 8, 2024 · 2 comments
Closed

Document that derive macros create impls for multiple traits #2037

lolbinarycat opened this issue Nov 8, 2024 · 2 comments

Comments

@lolbinarycat
Copy link

FromBytes adds and impl for FromZeros and TryFromBytes, while FromZeros adds an impl for TryFromBytes.

this does not match the typical behavior of derives, where not even supertraits are derived automatically (thus why you have to separately derive Clone and Copy).

this behavior is not documented.
jswrenn added a commit that referenced this issue Nov 8, 2024
@jswrenn
Document that derives imply supertraits, where applicable.
b3fbde8 
Fixes #2037
@jswrenn jswrenn mentioned this issue Nov 8, 2024
Merged
@jswrenn
Copy link
Collaborator

jswrenn commented Nov 8, 2024

I opened a PR to document this behavior: #2038

github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2024
@jswrenn
Document that derives imply supertraits, where applicable. (#2038)
af9179e 
Fixes #2037
google-pr-creation-bot pushed a commit to google-pr-creation-bot/zerocopy that referenced this issue Nov 8, 2024
@jswrenn
Document that derives imply supertraits, where applicable. (google#2038)
35f50e9 
Fixes google#2037
github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2024
@google-pr-creation-bot @jswrenn
Document that derives imply supertraits, where applicable. (#2038) (#…
af53999 
…2039)

Fixes #2037

Co-authored-by: Jack Wrenn <jswrenn@amazon.com>
@joshlf
Copy link
Member

joshlf commented Nov 14, 2024

Closed in #2038.

@joshlf joshlf closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshlf @jswrenn @lolbinarycat