Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deny warnings in UI tests #560

Open
jswrenn opened this issue Oct 27, 2023 · 1 comment
Open

Don't deny warnings in UI tests #560

jswrenn opened this issue Oct 27, 2023 · 1 comment

Comments

@jswrenn
Copy link
Collaborator

jswrenn commented Oct 27, 2023

As of #548, cargo.sh forwards RUSTFLAGS from the ambient environment to cargo. In CI, one such set flag is -Dwarnings, which elevates all warnings to errors. This impacts our UI tests: things which are, really, warnings, appear to be errors. Since the purpose of our UI tests is to confirm that compile errors are produced as expected on invalid code, this could lull us into a false sense of security if an "error" is really a warning.

Less pressingly, it currently means that all local trybuild runs during development need to be preceded by RUSTFLAGS="-Dwarnings" in order for the .stderr files to match in CI.

We need to prevent RUSTFLAGS from modifying lint levels when running UI tests. Ideally, this takes the form of porting to the ui-test crate, which I believe doesn't have this problem. See #187.

@joshlf joshlf changed the title Don't deny warnings in UI tests. Don't deny warnings in UI tests Oct 28, 2023
joshlf added a commit that referenced this issue Oct 28, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 28, 2023
@joshlf
Copy link
Member

joshlf commented Oct 6, 2024

@jswrenn Was this fixed by #567?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants