Merge pull request #429 from razvanbalosin/master

ProductPartitions::showAdGroupTree() - Check if child index was already exists
googleads · Dec 20, 2017 · 83e6297 · 83e6297
2 parents 455cdbd + 9936111
commit 83e6297
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/src/Google/AdsApi/AdWords/Shopping/v201702/ProductPartitions.php b/src/Google/AdsApi/AdWords/Shopping/v201702/ProductPartitions.php
@@ -241,7 +241,9 @@ public static function showAdGroupTree(AdWordsServices $adWordsServices,
       if ($page->getEntries() !== null) {
         $totalNumEntries = $page->getTotalNumEntries();
         foreach ($page->getEntries() as $adGroupCriterion) {
-          $children[$adGroupCriterion->getCriterion()->getId()] = [];
+          if (!array_key_exists($adGroupCriterion->getCriterion()->getId(), $children)) {
+            $children[$adGroupCriterion->getCriterion()->getId()] = [];
+          }
 
           if ($adGroupCriterion->getCriterion()->getParentCriterionId()
               !== null) {

diff --git a/src/Google/AdsApi/AdWords/Shopping/v201705/ProductPartitions.php b/src/Google/AdsApi/AdWords/Shopping/v201705/ProductPartitions.php
@@ -241,7 +241,9 @@ public static function showAdGroupTree(AdWordsServices $adWordsServices,
       if ($page->getEntries() !== null) {
         $totalNumEntries = $page->getTotalNumEntries();
         foreach ($page->getEntries() as $adGroupCriterion) {
-          $children[$adGroupCriterion->getCriterion()->getId()] = [];
+          if (!array_key_exists($adGroupCriterion->getCriterion()->getId(), $children)) {
+            $children[$adGroupCriterion->getCriterion()->getId()] = [];
+          }
 
           if ($adGroupCriterion->getCriterion()->getParentCriterionId()
               !== null) {

diff --git a/src/Google/AdsApi/AdWords/Shopping/v201708/ProductPartitions.php b/src/Google/AdsApi/AdWords/Shopping/v201708/ProductPartitions.php
@@ -241,7 +241,9 @@ public static function showAdGroupTree(AdWordsServices $adWordsServices,
       if ($page->getEntries() !== null) {
         $totalNumEntries = $page->getTotalNumEntries();
         foreach ($page->getEntries() as $adGroupCriterion) {
-          $children[$adGroupCriterion->getCriterion()->getId()] = [];
+          if (!array_key_exists($adGroupCriterion->getCriterion()->getId(), $children)) {
+            $children[$adGroupCriterion->getCriterion()->getId()] = [];
+          }
 
           if ($adGroupCriterion->getCriterion()->getParentCriterionId()
               !== null) {

diff --git a/src/Google/AdsApi/AdWords/Shopping/v201710/ProductPartitions.php b/src/Google/AdsApi/AdWords/Shopping/v201710/ProductPartitions.php
@@ -241,7 +241,9 @@ public static function showAdGroupTree(AdWordsServices $adWordsServices,
       if ($page->getEntries() !== null) {
         $totalNumEntries = $page->getTotalNumEntries();
         foreach ($page->getEntries() as $adGroupCriterion) {
-          $children[$adGroupCriterion->getCriterion()->getId()] = [];
+          if (!array_key_exists($adGroupCriterion->getCriterion()->getId(), $children)) {
+            $children[$adGroupCriterion->getCriterion()->getId()] = [];
+          }
 
           if ($adGroupCriterion->getCriterion()->getParentCriterionId()
               !== null) {