Enforce gpt->pubads_impl edges in the simulation graph #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrengm
changed the title
jburger424
previously requested changes
Dec 9, 2019
jburger424
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edge is missing whenever gpt.js is prefetched since this introduces two gpt.js requests. As a result, Lighthouse fails to introduce an edge in https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/computed/page-dependency-graph.js#L150
A fix for this particular case in LH seems pretty straightforward but the there are some more general issues with prefetching in the simulation graph. (I'll file issues and/or PRs with some more investigation.) In the meantime, we can fix this on our fairly easily.