Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported modes to category #339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamraine
Copy link
Contributor

This change prevents the plugin from operating in "timespan" and "snapshot" modes which can be used to audit a page beyond the initial page load: https://github.com/GoogleChrome/lighthouse/blob/master/docs/user-flows.md. The "navigation" mode is how Lighthouse traditionally works.

Before this change, this plugin would emit errors in timespan mode because the trace does not always include events such as the FCP in timespan mode.

I think it's best to exclude the new modes for now to prevent errors from popping up in DevTools Lighthouse.

@jburger424 jburger424 self-requested a review April 26, 2022 20:51
@jburger424
Copy link
Contributor

From the presubmit failures, it looks like we'll need to update our version of lighthouse to support this change.

Do you want to make that change in this PR, or would you prefer that I do it in a separate PR first?

@adamraine
Copy link
Contributor Author

From the presubmit failures, it looks like we'll need to update our version of lighthouse to support this change.

Hmm the PR that added the filter should be included in 8.6.0 GoogleChrome/lighthouse#13161

@jburger424
Copy link
Contributor

From the presubmit failures, it looks like we'll need to update our version of lighthouse to support this change.

Hmm the PR that added the filter should be included in 8.6.0 GoogleChrome/lighthouse#13161

I think a change will need to be made here to support this setting for plugins: https://github.com/GoogleChrome/lighthouse/blob/bfa5351639f81ea8a034bed6fb752864ff71f580/lighthouse-core/config/config-plugin.js#L127

@adamraine
Copy link
Contributor Author

I think you are right, I'll make the change in Lighthouse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants