Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let DescriptorSource include source code info in multiple files #100

Closed
mingzhi opened this issue Jun 25, 2019 · 1 comment
Closed

Let DescriptorSource include source code info in multiple files #100

mingzhi opened this issue Jun 25, 2019 · 1 comment
Assignees
@mingzhi

Comments

@mingzhi
Copy link
Contributor

mingzhi commented Jun 25, 2019

Currently, DescriptorSource only contains the source code info in a single file, but linter may want to check descriptors across files, e.g., a service may include the request and response message in a different file.

We may let DescriptorSource use {filename, path} as the key to lookup the source code info (currently, we only use path as the key).
@mingzhi
Copy link
Contributor Author

mingzhi commented Jul 11, 2019

#109

@mingzhi mingzhi closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mingzhi mingzhi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mingzhi