Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DescriptorSource #109

Closed
mingzhi opened this issue Jul 11, 2019 · 1 comment
Closed

Remove DescriptorSource #109

mingzhi opened this issue Jul 11, 2019 · 1 comment
Assignees
@mingzhi

Comments

@mingzhi
Copy link
Contributor

mingzhi commented Jul 11, 2019

Remove DescriptorSource once protoreflect package supports source code info.
@mingzhi mingzhi mentioned this issue Jul 11, 2019
Closed
@mingzhi
Copy link
Contributor Author

mingzhi commented Jul 22, 2019

Supporting source code info lookup in descriptors is not that easy in the protoreflect library, see golang/protobuf#899. So I am closing this issue now -- we can reopen it once protoreflect has decided the interface.

@mingzhi mingzhi closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mingzhi mingzhi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mingzhi