feat: remove legacy list revisions rules #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-scripniciuc
approved these changes
Feb 29, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
🤖 I have created a release *beep* *boop* --- ## [1.64.0](https://togithub.com/googleapis/api-linter/compare/v1.63.6...v1.64.0) (2024-03-04) ### Features * remove legacy list revisions rules ([#1348](https://togithub.com/googleapis/api-linter/issues/1348)) ([2bc5c57](https://togithub.com/googleapis/api-linter/commit/2bc5c574eb2e33aee2df502bd3b70454dbfae542)) ### Documentation * **AIP-191:** remove ambiguity in java_outer_classname ([#1345](https://togithub.com/googleapis/api-linter/issues/1345)) ([1d8d76d](https://togithub.com/googleapis/api-linter/commit/1d8d76d561e5042735c63fa23ec26c7520d11498)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With AIP-162 moving towards a new design that is incompatible with the previous (known as "legacy" from here on), the same rules for List Revisions APIs no longer apply, and directly conflict with Standard List APIs. All of the legacy list revisions rules are deleted.
Now, instead of excluding
List{Resource}Revisionsmethods from the scope of Standard List methods, we will exclude legacy list revision methods from the scope of Standard List. Legacy methods are identified as follows:List{Resource}Revisionsstring namefield instead ofstring parent:listRevisionsHTTP uri suffixNote: If the RPC does not have a
google.api.httpbinding to check for the suffix, fulfilling the first two aspects will be sufficient to identify a legacy method.This means that all "new" list revisions methods will adhere to Standard List structure AIP-132.
Addresses internal bug