Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify gax so it will run with either Poison 3 or Poison 4. Fixes #1232.
We check at compile time for
Poison.Decode.decode/2
which exists in Poison 3 but was renamed toPoison.Decode.transform/2
in Poison 4, and generate different versions of the functionGoogleApis.Gax.ModelBase.poison_transform/2
in response, to call the appropriate Poison function.This also includes two Poison 4 specific fixes:
Map
. Most calls perform automatic conversion fromKeyword
, butPoison.Decode.transform
doesn't. So we alter our call points accordingly.transform
if the input is already a struct.