Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gengapic): fix linkParser regexp to support multi-line link tags #1098

Merged
merged 2 commits into from
Aug 4, 2022
Merged

fix(gengapic): fix linkParser regexp to support multi-line link tags #1098

merged 2 commits into from
Aug 4, 2022

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Aug 4, 2022

closes: #1097

@quartzmo quartzmo requested review from a team as code owners August 4, 2022 19:58
@quartzmo
Copy link
Member Author

quartzmo commented Aug 4, 2022

@noahdietz Build error in compute-regen is:

[/home/runner/work/gapic-generator-go/gapic-generator-go] >>>> gofmt -s -d -w -l . <<<<
go: downloading github.com/googleapis/gax-go/v2 v2.5.0
go: downloading github.com/googleapis/gax-go v1.0.3
go: downloading golang.org/x/oauth2 v0.0.0-20220722155238-128564f6959c
go: downloading golang.org/x/net v0.0.0-20220802222814-0bcc04d9c69b
go: downloading google.golang.org/appengine v1.6.7
go: downloading golang.org/x/sys v0.0.0-20220804182731-e052cef7d300
go: downloading github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da
go: loading module retractions for github.com/googleapis/gax-go/v2@v2.0.1: parsing go.mod: go.mod:8:2: require google.golang.org/genproto: version "b98a9ff5e252" invalid: must be of the form v1.2.3
Error: Process completed with exit code 1.

Any suggestions?

@noahdietz
Copy link
Collaborator

@quartzmo uh oh...I think that means a bad pseudo-version was introduced into a go.mod/sum, but I'm not sure...I will look at it.

@quartzmo quartzmo enabled auto-merge (squash) August 4, 2022 23:26
@quartzmo quartzmo merged commit 863675e into googleapis:main Aug 4, 2022
@release-please release-please bot mentioned this pull request Aug 4, 2022
Merged
@quartzmo quartzmo deleted the markdown-regex branch August 4, 2022 23:30
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 16, 2022
@release-please
chore(main): release 0.32.0 (#1089)
a4d13ee 
🤖 I have created a release *beep* *boop*
---


## [0.32.0](v0.31.2...v0.32.0) (2022-08-16)


### Features

* **gengapic:** rest-numeric-enums option enables enum-encoding sys param ([#1022](#1022)) ([6bbbf6f](6bbbf6f))


### Bug Fixes

* **gengapic:** fix linkParser regexp to support multi-line link tags ([#1098](#1098)) ([863675e](863675e)), closes [#1097](#1097)
* **gengapic:** fix service-specific constructor name in doc_file.go ([#1099](#1099)) ([4f80726](4f80726)), closes [#1077](#1077)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gengapic: fix linkParser regexp to support multi-line link tags
2 participants
@quartzmo @noahdietz