feat(gengapic): rest-numeric-enums option enables enum-encoding sys param #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
reviewed
Jun 8, 2022
noahdietz
added
the
do not merge
codyoss
approved these changes
Jun 8, 2022
vchudnov-g
approved these changes
Jun 9, 2022
|
Oh, one question: are you planning on encoding all enums as ints when sending the request too? We think that would be desirable for symmetry. |
That was already done in #994 :) |
|
Oh, right! Great! |
noahdietz
added
disable job: compute-regen
|
@vchudnov-g are we good to merge/release this yet? Thanks |
|
@noahdietz No, let's not merge this yet. The server changes have not been rolled out yet. |
noahdietz
removed
the
do not merge
noahdietz
changed the title
noahdietz
force-pushed
the
regapic-enum-encoding
branch
from
b617cab
to
df99820
Compare
vchudnov-g
reviewed
Jul 20, 2022
vchudnov-g
approved these changes
Jul 20, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
🤖 I have created a release *beep* *boop* --- ## [0.32.0](v0.31.2...v0.32.0) (2022-08-16) ### Features * **gengapic:** rest-numeric-enums option enables enum-encoding sys param ([#1022](#1022)) ([6bbbf6f](6bbbf6f)) ### Bug Fixes * **gengapic:** fix linkParser regexp to support multi-line link tags ([#1098](#1098)) ([863675e](863675e)), closes [#1097](#1097) * **gengapic:** fix service-specific constructor name in doc_file.go ([#1099](#1099)) ([4f80726](4f80726)), closes [#1077](#1077) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For REGAPIC API calls, when the
rest-numeric-enumsplugin option is provided, include the new system parameter variant of$alt=jsonthat enables proto-json encoding of enums in server responses as integers -enum-encoding=int. The default is false. Includes the bazel attribute as well.Also updates the README with option documentation.
Requested in http://b/232457394.