Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make iter error handling clearer #1561

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix: make iter error handling clearer #1561

merged 2 commits into from
Dec 6, 2024

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 23, 2024

No description provided.

@codyoss codyoss requested review from a team as code owners August 23, 2024 15:47
quartzmo
quartzmo approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition.

Another possibility might be:

// TODO: Handle error. Iteration will stop after any error.
break

@codyoss codyoss added the automerge Summon MOG for automerging label Dec 6, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit dc5af4e into googleapis:main Dec 6, 2024
7 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Dec 6, 2024
@release-please release-please bot mentioned this pull request Dec 6, 2024
Merged
@codyoss codyoss deleted the page-doc-2 branch December 6, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codyoss @quartzmo