Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct retry deadline in publisher methods #814

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Mar 15, 2021

Fixes #794.

This PR makes sure that correct Retry deadline is used in publisher methods. Should fix googleapis/python-pubsub#303 when the Python PubSub code is re-generated.

@plamut plamut requested a review from a team as a code owner March 15, 2021 09:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #814 (1302d6a) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #814   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1653   +45     
  Branches       328       337    +9     
=========================================
+ Hits          1608      1653   +45     
Impacted Files Coverage Δ
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
gapic/utils/checks.py 100.00% <100.00%> (ø)
gapic/utils/options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b8f71...1302d6a. Read the comment docs.

Copy link
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add the same change to the ads template?

@plamut
Copy link
Contributor Author

plamut commented Mar 16, 2021

Done, and the same for the async client template, PTAL.

BTW, for future reference, what are ads-templates anyway?

@plamut plamut requested a review from software-dov March 16, 2021 13:07
@software-dov
Copy link
Contributor

For really frustrating, annoying reasons, the Ads team has special requirements for their GAPIC; the easiest solution is to just have a separate, mostly identical set of templates for them.

The big difference that they required has to do with multiple version subdirectories.
The regular templates make a directory something like:
google/cloud/kms_v1/

ads wants something like:
google/ads/googleads/v6

It also makes it easier to support their lazy load feature, which requires python 3.7, but the other gapics must support 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
2 participants