-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct retry deadline in publisher methods #814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1653 +45
Branches 328 337 +9
=========================================
+ Hits 1608 1653 +45
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you add the same change to the ads template?
Done, and the same for the async client template, PTAL. BTW, for future reference, what are |
For really frustrating, annoying reasons, the Ads team has special requirements for their GAPIC; the easiest solution is to just have a separate, mostly identical set of templates for them. The big difference that they required has to do with multiple version subdirectories. ads wants something like: It also makes it easier to support their lazy load feature, which requires python 3.7, but the other gapics must support 3.6. |
🤖 I have created a release \*beep\* \*boop\* --- ### [0.43.1](https://www.github.com/googleapis/gapic-generator-python/compare/v0.43.0...v0.43.1) (2021-03-19) ### Bug Fixes * use correct retry deadline in publisher methods ([#814](https://www.github.com/googleapis/gapic-generator-python/issues/814)) ([92a2cfc](https://www.github.com/googleapis/gapic-generator-python/commit/92a2cfc47b24c4b1a041d5bbb944d69a67a962a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Fixes #794.
This PR makes sure that correct Retry deadline is used in publisher methods. Should fix googleapis/python-pubsub#303 when the Python PubSub code is re-generated.