Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Unit tests. #115

Merged
merged 7 commits into from
Apr 2, 2019
Merged

[feat] Unit tests. #115

merged 7 commits into from
Apr 2, 2019

Conversation

lukesneeringer
Copy link
Contributor

This commit adds full unit tests (with full coverage) to the output from the generator.

This commit adds full unit tests (with full coverage) to the output
from the generator.
@lukesneeringer lukesneeringer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 31, 2019
@lukesneeringer
Copy link
Contributor Author

Adding a do not merge label until I configure CI to run these on the Showcase output.

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #115   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         720    746   +26     
  Branches      149    159   +10     
=====================================
+ Hits          720    746   +26
Impacted Files Coverage Δ
gapic/schema/metadata.py 100% <ø> (ø) ⬆️
gapic/schema/wrappers.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f222aa...d6d3d3f. Read the comment docs.

@lukesneeringer lukesneeringer force-pushed the unit-tests branch 2 times, most recently from 312e3cc to 6bcc413 Compare April 1, 2019 06:28
@lukesneeringer
Copy link
Contributor Author

CI is in place; ready to merge.

@lukesneeringer lukesneeringer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 1, 2019
@lukesneeringer lukesneeringer merged commit c207846 into master Apr 2, 2019
@lukesneeringer lukesneeringer deleted the unit-tests branch April 2, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants