fix: add context manager return types #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henribru
force-pushed
the
context-manager-return-type
branch
from
4fc665e to
442fbfa
Compare
henribru
changed the title
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
previously approved these changes
Jan 9, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
parthea
added
the
automerge: exact
gcf-merge-on-green
bot
dismissed
parthea’s stale review
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
parthea
approved these changes
Jan 9, 2023
gcf-merge-on-green
bot
removed
the
automerge: exact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
__enter__method of a service client has no annotated return type. While some type checkers infer return types, Mypy doesn't, so this means that in a statement likewith FooClient(...) as client:,clientends up asAnyif you use Mypy. This PR simply makes the very small change of explicitly annotating this return type (due to its size and simplicity it seemed overkill to create an issue first).