Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix docstring with proto-plus dependency #1624

Merged
merged 8 commits into from
Mar 21, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 17, 2023

This PR fixes an issue where a field has an incorrect type in docstrings when it is a proto-plus type.
Fixes #1625
Googlers see go/fix-gapic-depends-on-gapic-with-proto-plus-types

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 17, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 17, 2023
@parthea parthea changed the title [WIP] docs: fix docstring with proto-plus dependency docs: fix docstring with proto-plus dependency Mar 20, 2023
@parthea parthea marked this pull request as ready for review March 20, 2023 15:52
@parthea parthea requested review from a team as code owners March 20, 2023 15:52
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 20, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Mar 21, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2023
@parthea parthea merged commit dce071d into main Mar 21, 2023
@parthea parthea deleted the fix-docstring-with-proto-plus-dependency branch March 21, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with docstring in generated code when dependency is a proto-plus type
2 participants