fix(revert): partial revert of #1125 #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
approved these changes
Oct 12, 2023
vchudnov-g
reviewed
Oct 16, 2023
| @@ -713,7 +713,7 @@ def with_context(self, *, | |||
| references. | |||
| """ | |||
| visited_messages = visited_messages or set() | |||
| visited_messages.add(self) | |||
| visited_messages = visited_messages | {self} | |||
There was a problem hiding this comment.
@parthea How is adding an element b to a set A different than updating A to be the union of A and {b}?
There was a problem hiding this comment.
Great question. I don't have the answer. Issue #1794 is still open to try to create a minimal reproduction of the issue to dig deeper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #1125 to fix the issue captured in #1794. I wasn't able to create a minimal reproduction. We should keep #1794 open until we can create a minimal test for the issue.