-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial sample generation documentation #184
Conversation
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 1197 1197
Branches 259 259
=====================================
Hits 1197 1197 Continue to review full report at Codecov.
|
Add an image to docker invocation example Consume '--samples' option in entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, particularly about finding a SPOT for the repeated content.
docs/getting-started/docker.rst
Outdated
~~~~~~~~~~~~~~~~~~ | ||
|
||
In addition to generating client libraries, the generator can also create standalone | ||
executable code samples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: line wrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite sure what you mean. Other rst files use 80 columns max, and the resulting html is single-newline agnostic.
docs/getting-started/local.rst
Outdated
~~~~~~~~~~~~~~~~~~ | ||
|
||
In addition to generating client libraries, the generator can also create standalone | ||
executable code samples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: line wrap
Lighthearted aside: 'finding a SPOT' works both as an expanded and unexpanded acronym. A.C.R.O.N.Y.M.: A Criminal Regiment Of Nasty Young Men |
No description provided.