Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dependency google-apps-card #1971

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix: fix dependency google-apps-card #1971

merged 2 commits into from
Mar 15, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 5, 2024

In #1964, dependency google-apps-card was added to gapic/templates/_pypi_packages.j2

{% set pypi_packages = {
("google", "apps", "card"): {"package_name": "google-apps-card", "lower_bound": "0.1.0", "upper_bound": "1.0.0dev"},

The entry is ("google", "apps", "card") but it should have been ("google", "apps", "card", "v1")

@parthea parthea requested a review from a team as a code owner March 5, 2024 20:14
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 5, 2024
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Mar 5, 2024
@parthea parthea merged commit 9a49cb0 into main Mar 15, 2024
67 checks passed
@parthea parthea deleted the parthea-patch-3 branch March 15, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants