Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for reading ClientLibrarySettings from service configuration YAML #2098

Merged
merged 4 commits into from
Aug 29, 2024
Merged

feat: Add support for reading ClientLibrarySettings from service configuration YAML #2098

merged 4 commits into from
Aug 29, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 13, 2024 •
edited
Loading

Fixes b/356854861

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 13, 2024
@parthea parthea force-pushed the add-support-for-library-settings branch from 45e98c8 to 123e20e Compare August 26, 2024 14:42
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 26, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2024
@parthea parthea marked this pull request as ready for review August 27, 2024 16:59
@parthea parthea requested a review from a team as a code owner August 27, 2024 16:59
@parthea parthea assigned ohmayr and vchudnov-g and unassigned vchudnov-g Aug 27, 2024
@parthea parthea requested review from vchudnov-g and ohmayr August 27, 2024 17:00
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. size: m Pull request size is medium. and removed size: m Pull request size is medium. size: xl Pull request size is extra large. labels Aug 27, 2024
@parthea parthea force-pushed the add-support-for-library-settings branch from f830377 to ffb23fa Compare August 27, 2024 18:50
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Aug 27, 2024
@parthea parthea force-pushed the add-support-for-library-settings branch from ffb23fa to 0c5e098 Compare August 27, 2024 18:51
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Aug 27, 2024
ohmayr
ohmayr approved these changes Aug 28, 2024
View reviewed changes
gapic/schema/api.py Outdated Show resolved Hide resolved
gapic/schema/api.py Outdated Show resolved Hide resolved
@parthea parthea enabled auto-merge (squash) August 29, 2024 15:04
@parthea parthea merged commit 11e3967 into main Aug 29, 2024
67 checks passed
@parthea parthea deleted the add-support-for-library-settings branch August 29, 2024 15:08
@release-please release-please bot mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr ohmayr approved these changes

@vchudnov-g vchudnov-g Awaiting requested review from vchudnov-g

Assignees

@vchudnov-g vchudnov-g

@ohmayr ohmayr

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @ohmayr @vchudnov-g