Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optionally generate async rest and client files #2122

Merged
merged 2 commits into from
Sep 4, 2024
Merged

chore: optionally generate async rest and client files #2122

merged 2 commits into from
Sep 4, 2024

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Aug 31, 2024 •
edited
Loading

This PR leverages the client settings to optionally generate the following files:

  • async_client.py if gRPC is a required as a transport or rest_async_io_enabled is True.
  • rest_asyncio.py if rest_async_io_enabled is True.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 31, 2024
@ohmayr ohmayr marked this pull request as ready for review September 3, 2024 14:18
@ohmayr ohmayr requested a review from a team as a code owner September 3, 2024 14:18
@parthea parthea assigned ohmayr and unassigned parthea Sep 3, 2024
@ohmayr ohmayr force-pushed the async-rest-initial branch 2 times, most recently from dd34d55 to aa4bfa6 Compare September 3, 2024 20:35
@ohmayr ohmayr force-pushed the async-rest-initial branch from aa4bfa6 to d9f8d2b Compare September 3, 2024 20:36
parthea
parthea approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added non-blocking comment.

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest_asyncio.py.j2 Show resolved Hide resolved
@ohmayr ohmayr merged commit bb7bac9 into main Sep 4, 2024
67 checks passed
@ohmayr ohmayr deleted the async-rest-initial branch September 4, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees

@parthea parthea

@vchudnov-g vchudnov-g

@ohmayr ohmayr

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohmayr @parthea @vchudnov-g