Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow google-cloud-documentai 3.x #2237

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: allow google-cloud-documentai 3.x #2237

merged 1 commit into from
Oct 25, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 25, 2024

google-cloud-documentai 3.0.0 will be released next week. We need to bump the upper bound in _pypi_packages.j2

("google", "cloud", "documentai", "v1"): {"package_name": "google-cloud-documentai", "lower_bound": "2.0.0", "upper_bound": "3.0.0dev"},

https://pypi.org/project/google-cloud-documentai

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 25, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2024
@parthea parthea marked this pull request as ready for review October 25, 2024 17:13
@parthea parthea requested a review from a team as a code owner October 25, 2024 17:13
@ohmayr
Copy link
Contributor

ohmayr commented Oct 25, 2024

Why do we even have an upper bound if we're allowing the latest every time?

@parthea
Copy link
Contributor Author

parthea commented Oct 25, 2024

Why do we even have an upper bound if we're allowing the latest every time?

We can't guarantee that the next major version of a dependency will be compatible. By restricting the major version of dependencies, we know that what we ship won't break later when there is a breaking change in a dependency. Googlers see related issue b/234875462

@parthea parthea merged commit 946adf1 into main Oct 25, 2024
85 checks passed
@parthea parthea deleted the parthea-patch-6 branch October 25, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants