chore: add template for metadata #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
ohmayr
reviewed
Nov 19, 2024
| @@ -631,7 +631,7 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta): | |||
| *, | |||
| retry: OptionalRetry = gapic_v1.method.DEFAULT, | |||
| timeout: Union[float, object] = gapic_v1.method.DEFAULT, | |||
| metadata: Sequence[Tuple[str, str]] = (), | |||
| {{ shared_macros.client_method_metadata_argument()|indent(8) }} = {{ shared_macros.client_method_metadata_default_value() }}, | |||
There was a problem hiding this comment.
I think these macros are no longer used and are adding a toil to whenever a change needs to be made to the client methods i.e. see the linked comment above.
I'd suggest to get rid of these macros.
There was a problem hiding this comment.
I filed #2255 for this clean up step. We still need to remove usage here: https://github.com/search?q=repo%3Agoogleapis%2Fgoogleapis%20add-iam-methods&type=code
product-auto-label
bot
added
size: l
This reverts commit a06fdae.
product-auto-label
bot
added
size: m
ohmayr
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2250